Re: [PATCH 1/2] ASoC: audio-graph: Export graph_remove() function

From: Sameer Pujar
Date: Wed Feb 03 2021 - 22:47:26 EST




On 2/4/2021 4:03 AM, Kuninori Morimoto wrote:
External email: Use caution opening links or attachments


Hi

+int graph_remove(struct platform_device *pdev);
I think this needs better namespacing if it's going to be exported.
audio_graph_remove() can be a better choice?
Yeah, that looks reasonable.
Nice naming I think.
In such case, update also graph_parse_of() is nice idea for me.

- int graph_parse_of(...)
+ int audio_graph_parse_of()

OK, Will update following.

graph_remove()     --> audio_graph_remove()
graph_parse_of()   --> audio_graph_parse_of()
graph_card_probe() --> audio_graph_card_probe()