Re: [PATCH V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c

From: Randy Dunlap
Date: Wed Feb 03 2021 - 21:11:04 EST


On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote:
>
> s/initialsation/initialisation/
> s/specifiing/specifying/
>
> Plus get rid of few blank lines.
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx>
> ---
> Changes from V1:
> Fix typo in the subject line
> Give explanation of all the changes in changelog text
>
> drivers/net/ethernet/i825xx/ether1.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c
> index a0bfb509e002..850ea32091ed 100644
> --- a/drivers/net/ethernet/i825xx/ether1.c
> +++ b/drivers/net/ethernet/i825xx/ether1.c

a. don't delete the blank lines
b. the change below is not described and does not change any whitespace AFAICT.
I.e., DDT [don't do that].

> @@ -1047,7 +1044,7 @@ static void ether1_remove(struct expansion_card *ec)
> {
> struct net_device *dev = ecard_get_drvdata(ec);
>
> - ecard_set_drvdata(ec, NULL);
> + ecard_set_drvdata(ec, NULL);
>
> unregister_netdev(dev);
> free_netdev(dev);


--
~Randy