Re: [PATCH 1/2] misc/pvpanic: split-up generic and platform dependent code

From: Randy Dunlap
Date: Wed Feb 03 2021 - 12:14:51 EST


On 2/3/21 6:43 AM, Mihai Carabas wrote:
> diff --git a/drivers/misc/pvpanic/Kconfig b/drivers/misc/pvpanic/Kconfig
> new file mode 100644
> index 00000000..12bb017
> --- /dev/null
> +++ b/drivers/misc/pvpanic/Kconfig
> @@ -0,0 +1,14 @@
> +config PVPANIC
> + bool "pvpanic device support"
> + depends on PVPANIC_MMIO
> + help
> + This option enable generic code for pvpanic device driver logic.
> +
> +config PVPANIC_MMIO
> + tristate "pvpanic mmio device support"

MMIO


Also capitalize PCI in the other patch in the similar location.

> + depends on HAS_IOMEM && (ACPI || OF)
> + select PVPANIC
> + help
> + This driver provides support for the pvpanic device. pvpanic is
> + a paravirtualized device provided by QEMU; it lets a virtual machine
> + (guest) communicate panic events to the host.


thanks.
--
~Randy