RE: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI settings

[Kostya Porotchkin]

Hi, Baruch,

> -----Original Message-----
> From: Baruch Siach <baruch@xxxxxxxxxx>
> Sent: Wednesday, February 3, 2021 15:59
> To: Kostya Porotchkin <kostap@xxxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> andrew@xxxxxxx; jaz@xxxxxxxxxxxx; gregory.clement@xxxxxxxxxxx;
> linux@xxxxxxxxxxxxxxx; Nadav Haklai <nadavh@xxxxxxxxxxx>;
> robh+dt@xxxxxxxxxx; Stefan Chulski <stefanc@xxxxxxxxxxx>;
> mw@xxxxxxxxxxxx; Ben Peled <bpeled@xxxxxxxxxxx>;
> sebastian.hesselbarth@xxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH 02/11] dts: mvebu: Update A8K AP806 SDHCI
> settings
> 
> External Email
> 
> ----------------------------------------------------------------------
> Hi Konstantin,
> 
> On Wed, Feb 03 2021, kostap@xxxxxxxxxxx wrote:
> > From: Konstantin Porotchkin <kostap@xxxxxxxxxxx>
> >
> > Update the settings for AP806 SDHCI interface according to latest
> > Xenon drivers changes.
> > - no need to select the PHY slow mode anymore
> 
> Why? Has anything changed since the introduction of marvell,xenon-phy-slow-
> mode?
[KP] AP806 B0, AP807 and later do not need the "slow mode" set by the default.
The HWE-7296210 errata is not applicable to these components and they are able 
to run  AP SDHCI in HS400 8-bit mode.

Kosta
> 
> baruch
> 
> > -	 * Not stable in HS modes - phy needs "more calibration", so add
> > -	 * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes.
> > -	 */
> > -	marvell,xenon-phy-slow-mode;
> >  	no-1-8-v;
> >  	no-sd;
> >  	no-sdio;
> > diff --git a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> > b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> > index 12e477f1aeb9..edd6131a0587 100644
> > --- a/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> > +++ b/arch/arm64/boot/dts/marvell/armada-ap80x.dtsi
> > @@ -257,7 +257,6 @@
> >  				clock-names = "core";
> >  				clocks = <&ap_clk 4>;
> >  				dma-coherent;
> > -				marvell,xenon-phy-slow-mode;
> >  				status = "disabled";
> >  			};
> 
> 
> --
>                                                      ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch@xxxxxxxxxx - tel: +972.52.368.4656,
> https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__www.tkos.co.il&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=-
> N9sN4p5NSr0JGQoQ_2UCOgAqajG99W1EbSOww0WU8o&m=F567knLB6kbyr-
> BZRqLFLJgXHENu41578OHxsKQQ-
> sw&s=eXEBLtBC3CwWIF9XFbHrgSgASz4aMgHi5W1uuXTgdQ4&e=  -