Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

From: Andrew Jeffery
Date: Tue Feb 02 2021 - 17:30:59 EST




On Wed, 3 Feb 2021, at 07:25, Rob Herring wrote:
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <sboyd@xxxxxxxxxx>
> Cc: Maxime Ripard <mripard@xxxxxxxxxx>
> Cc: Chen-Yu Tsai <wens@xxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Daniel Palmer <daniel@xxxxxxxxx>
> Cc: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> Cc: Avi Fishman <avifishman70@xxxxxxxxx>
> Cc: Tomer Maimon <tmaimon77@xxxxxxxxx>
> Cc: Tali Perry <tali.perry1@xxxxxxxxx>
> Cc: Joerg Roedel <joro@xxxxxxxxxx>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Cc: Andrew Jeffery <andrew@xxxxxxxx>
> Cc: Joel Stanley <joel@xxxxxxxxx>
> Cc: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> Cc: Vincent Cheng <vincent.cheng.xh@xxxxxxxxxxx>
> Cc: linux-clk@xxxxxxxxxxxxxxx
> Cc: linux-crypto@xxxxxxxxxxxxxxx
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Cc: linux-i2c@xxxxxxxxxxxxxxx
> Cc: iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx
> Cc: linux-watchdog@xxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> .../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml | 2 +-
> Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 4 ++--
> Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 2 +-
> Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml | 2 +-
> .../devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 2 +-
> .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 +-
> Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml | 4 +---
> Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
> 11 files changed, 13 insertions(+), 15 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> index fa0ee03a527f..53cc6df0df96 100644
> ---
> a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> +++
> b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> @@ -18,7 +18,7 @@ properties:
> const: 1
>
> compatible:
> - const: allwinner,sun9i-a80-usb-clocks
> + const: allwinner,sun9i-a80-usb-clks
>
> reg:
> maxItems: 1
> diff --git
> a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> index eb241587efd1..118c5543e037 100644
> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> @@ -66,8 +66,8 @@ properties:
> - arm,syscon-icst525-integratorcp-cm-mem
> - arm,integrator-cm-auxosc
> - arm,versatile-cm-auxosc
> - - arm,impd-vco1
> - - arm,impd-vco2
> + - arm,impd1-vco1
> + - arm,impd1-vco2
>
> clocks:
> description: Parent clock for the ICST VCO
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 1465c9ebaf93..1d48ac712b23 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -66,7 +66,7 @@ examples:
> #include <dt-bindings/soc/ti,sci_pm_domain.h>
>
> main_crypto: crypto@4e00000 {
> - compatible = "ti,j721-sa2ul";
> + compatible = "ti,j721e-sa2ul";
> reg = <0x4e00000 0x1200>;
> power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
> dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
> diff --git
> a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> index 1f2ef408bb43..fe1e1c63ffe3 100644
> --- a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> @@ -46,7 +46,7 @@ examples:
> #include <dt-bindings/gpio/msc313-gpio.h>
>
> gpio: gpio@207800 {
> - compatible = "mstar,msc313e-gpio";
> + compatible = "mstar,msc313-gpio";
> #gpio-cells = <2>;
> reg = <0x207800 0x200>;
> gpio-controller;
> diff --git
> a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> index e3ef2d36f372..128444942aec 100644
> --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> @@ -17,7 +17,7 @@ maintainers:
>
> properties:
> compatible:
> - const: nuvoton,npcm7xx-i2c
> + const: nuvoton,npcm750-i2c
>
> reg:
> maxItems: 1
> diff --git
> a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> index cde1afa8dfd6..349633108bbd 100644
> --- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> @@ -93,7 +93,7 @@ examples:
> #include <dt-bindings/power/r8a7791-sysc.h>
>
> ipmmu_mx: iommu@fe951000 {
> - compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
> + compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
> reg = <0xfe951000 0x1000>;
> interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> index 54631dc1adb0..5dbb84049ff6 100644
> ---
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> +++
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> @@ -63,7 +63,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g4-pinctrl";
> + compatible = "aspeed,ast2400-pinctrl";
>
> pinctrl_i2c3_default: i2c3_default {
> function = "I2C3";
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> index a90c0fe0495f..ad1c33364b38 100644
> ---
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> +++
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> @@ -81,7 +81,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g5-pinctrl";
> + compatible = "aspeed,ast2500-pinctrl";
> aspeed,external-nodes = <&gfx>, <&lhc>;
>
> pinctrl_i2c3_default: i2c3_default {
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> index c78ab7e2eee7..ad91c0bc54da 100644
> ---
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> +++
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> @@ -95,7 +95,7 @@ examples:
> reg = <0x1e6e2000 0xf6c>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g6-pinctrl";
> + compatible = "aspeed,ast2600-pinctrl";

Ah, thanks. For the Aspeed changes:

Reviewed-by: Andrew Jeffery <andrew@xxxxxxxx>