Re: [PATCH v2 1/3] VMCI: Stop log spew when qp allocation isn't possible

From: Firo Yang
Date: Tue Feb 02 2021 - 05:00:21 EST


The 01/20/2021 08:32, Jorgen Hansen wrote:
> VMCI queue pair allocation is disabled, if a VM is in FT mode. In
> these cases, VMware Tools may still once in a while attempt to
> create a vSocket stream connection, resulting in multiple
> warnings in the kernel logs. Therefore downgrade the error log to
> a debug log.
>
> Reviewed-by: Vishnu Dasa <vdasa@xxxxxxxxxx>
> Signed-off-by: Jorgen Hansen <jhansen@xxxxxxxxxx>
> ---
> drivers/misc/vmw_vmci/vmci_queue_pair.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/vmw_vmci/vmci_queue_pair.c b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> index c490658..a3691c1 100644
> --- a/drivers/misc/vmw_vmci/vmci_queue_pair.c
> +++ b/drivers/misc/vmw_vmci/vmci_queue_pair.c
> @@ -1207,7 +1207,7 @@ static int qp_alloc_guest_work(struct vmci_handle *handle,
> } else {
> result = qp_alloc_hypercall(queue_pair_entry);
> if (result < VMCI_SUCCESS) {
> - pr_warn("qp_alloc_hypercall result = %d\n", result);
> + pr_devel("qp_alloc_hypercall result = %d\n", result);

Hi Jorgen, recently, our customer reported that their dmesg was also
swamped by the following message along with the message above.

"Could not attach to queue pair with -20"

This message was printed by vmci_transport_queue_pair_alloc(). Could
we also eliminate it?

Thanks,
Firo


> goto error;
> }
> }
> --
> 2.6.2
>
> _______________________________________________
> Virtualization mailing list
> Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
> https://lists.linuxfoundation.org/mailman/listinfo/virtualization