Re: [linux-sunxi] Re: [PATCH v5 06/20] mfd: axp20x: Allow AXP chips without interrupt lines

From: Chen-Yu Tsai
Date: Tue Feb 02 2021 - 02:59:55 EST


On Thu, Jan 28, 2021 at 6:15 PM Maxime Ripard <maxime@xxxxxxxxxx> wrote:
>
> On Wed, Jan 27, 2021 at 05:24:46PM +0000, Andre Przywara wrote:
> > Currently the AXP chip requires to have its IRQ line connected to some
> > interrupt controller, and will fail probing when this is not the case.
> >
> > On a new Allwinner SoC (H616) there is no NMI pin anymore, and at
> > least one board does not connect the AXP's IRQ pin to anything else,
> > so the interrupt functionality of the AXP chip is simply not available.
> >
> > Check whether the interrupt line number returned by the platform code is
> > valid, before trying to register the irqchip. If not, we skip this
> > registration, to avoid the driver to bail out completely.
> >
> > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
>
> Acked-by: Maxime Ripard <mripard@xxxxxxxxxx>

Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>