Re: [PATCH v3 5/5] serial: 8250_dw: add em485 support

[Giulio Benetti]

Hi Andy,

Il 18/05/2020 17:21, Andy Shevchenko ha scritto:
> On Sun, May 17, 2020 at 11:56:10PM +0200, Heiko Stuebner wrote:
> > From: Giulio Benetti <giulio.benetti@xxxxxxxxxxxxxxxx>
> >
> > Need to use rs485 transceiver so let's use existing em485 485 emulation
> > layer on top of 8250.
> >
> > Add rs485_config callback to port and uses the standard em485 start and
> > stop helpers.
>
> Would it prevent to use native RS485 support?

8250_dw doesn't have a native RS485 support, do you mean using hardware
RTS assertion? Anyway at the moment it's not present. This would be the
first rs485 support added to 8250_dw.

Best regards
--
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale € 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

> ...
>
> >   	p->serial_out	= dw8250_serial_out;
> >   	p->set_ldisc	= dw8250_set_ldisc;
> >   	p->set_termios	= dw8250_set_termios;
> > +	p->rs485_config = serial8250_em485_config;
> > +	up->rs485_start_tx = serial8250_em485_start_tx;
> > +	up->rs485_stop_tx = serial8250_em485_stop_tx;