Re: [PATCH v12] staging: fbtft: add tearing signal detect

From: Andy Shevchenko
Date: Mon Feb 01 2021 - 12:41:41 EST


On Sat, Jan 30, 2021 at 8:39 AM carlis <zhangxuezhi3@xxxxxxxxx> wrote:
> On Fri, 29 Jan 2021 16:26:12 +0200
> Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
> > On Fri, Jan 29, 2021 at 3:56 PM carlis <zhangxuezhi3@xxxxxxxxx> wrote:
> > > On Fri, 29 Jan 2021 12:23:08 +0200
> > > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

...

> > > Hi, I apologize for what I said in the previous two emails. I missed
> > > one email you sent before, and now I probably understand what you
> > > meant. Here is a version I modified according to your suggestion:

I have realized that you are mocking stuff in the generic fbtft
structure for all drivers while only a single one is going to use
that. Consider moving everything to the driver in question.


--
With Best Regards,
Andy Shevchenko