[PATCH net-next v2 1/7] net: ipa: don't thaw channel if error starting

From: Alex Elder
Date: Mon Feb 01 2021 - 12:30:21 EST


If an error occurs starting a channel, don't "thaw" it.
We should assume the channel remains in a non-started state.

Update the comment in gsi_channel_stop(); calls to this function
are no longer retried.

Signed-off-by: Alex Elder <elder@xxxxxxxxxx>
---
drivers/net/ipa/gsi.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c
index f79cf3c327c1c..4a3e125e898f6 100644
--- a/drivers/net/ipa/gsi.c
+++ b/drivers/net/ipa/gsi.c
@@ -885,7 +885,9 @@ int gsi_channel_start(struct gsi *gsi, u32 channel_id)

mutex_unlock(&gsi->mutex);

- gsi_channel_thaw(channel);
+ /* Thaw the channel if successful */
+ if (!ret)
+ gsi_channel_thaw(channel);

return ret;
}
@@ -910,7 +912,7 @@ int gsi_channel_stop(struct gsi *gsi, u32 channel_id)

mutex_unlock(&gsi->mutex);

- /* Thaw the channel if we need to retry (or on error) */
+ /* Re-thaw the channel if an error occurred while stopping */
if (ret)
gsi_channel_thaw(channel);

--
2.27.0