Re: [PATCH 05/13] kallsyms: refactor {,module_}kallsyms_on_each_symbol

From: Christoph Hellwig
Date: Mon Feb 01 2021 - 11:29:56 EST


On Mon, Feb 01, 2021 at 02:37:12PM +0100, Miroslav Benes wrote:
> > > This change is not needed. (objname == NULL) means that we are
> > > interested only in symbols in "vmlinux".
> > >
> > > module_kallsyms_on_each_symbol(klp_find_callback, &args)
> > > will always fail when objname == NULL.
> >
> > I just tried to keep the old behavior. I can respin it with your
> > recommended change noting the change in behavior, though.
>
> Yes, please. It would be cleaner that way.

Let me know if this works for you:

---