Re: [PATCH 6/6] platform/chrome: cros_ec_typec: Set opmode to PD on SOP connected

From: Enric Balletbo i Serra
Date: Mon Feb 01 2021 - 09:35:40 EST


Hi Benson,

On 29/1/21 7:14, Benson Leung wrote:
> When SOP Discovery is done, set the opmode to PD if status indicates
> SOP is connected.
>
> SOP connected indicates a PD contract is in place, and is a solid
> indication we have transitioned to PD power negotiation, either as
> source or sink.
>
> Signed-off-by: Benson Leung <bleung@xxxxxxxxxxxx>

Acked-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>

> ---
> drivers/platform/chrome/cros_ec_typec.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 6bc6fafd54a4..a7778258d0a0 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -900,6 +900,9 @@ static void cros_typec_handle_status(struct cros_typec_data *typec, int port_num
> dev_err(typec->dev, "Couldn't parse SOP Disc data, port: %d\n", port_num);
> else
> typec->ports[port_num]->sop_disc_done = true;
> +
> + if (resp.sop_connected)
> + typec_set_pwr_opmode(typec->ports[port_num]->port, TYPEC_PWR_MODE_PD);
> }
>
> if (resp.events & PD_STATUS_EVENT_SOP_PRIME_DISC_DONE &&
>