Re: [PATCH v1] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

[Martin Kaiser]

Thus wrote Saravana Kannan (saravanak@xxxxxxxxxx):

> On Sun, Jan 31, 2021 at 5:26 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:

> > Hi Saravana,

> > On Sun, Jan 31, 2021 at 5:56 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:

> > > +static int __init imx_avic_init(struct device_node *node,
> > > +                              struct device_node *parent)
> > > +{
> > > +       void __iomem *avic_base;
> > > +
> > > +       avic_base = of_iomap(node, 0);
> > > +       BUG_ON(!avic_base);
> > > +       mxc_init_irq(avic_base);
> > > +       return 0;
> > > +}
> > > +
> > > +IRQCHIP_DECLARE(imx_avic, "fsl,imx31-avic", imx_avic_init);

> > Shouldn't the compatible be "fsl,avic" instead?

> Fabio,

> Ah yes. I had that too. I deleted the wrong one in the last minute
> before sending it out. Thanks for catching it.

> I'll wait to see if there are any other review comments before I send out v2.

> Martin,

> Please make this fix before you test it.

> -Saravana

with fsl,avic

Tested-by: Martin Kaiser <martin@xxxxxxxxx>