Re: [PATCH] bluetooth: fix memory leak in btusb_mtk_wmt_recv

From: Marcel Holtmann
Date: Mon Feb 01 2021 - 05:46:09 EST


Hi Jupeng,

>>>> In btusb_mtk_wmt_recv if skb_clone fails, the alocated skb should
>>>> be released.
>>>>
>>>> Signed-off-by: zhongjupeng <zhongjupeng@xxxxxxxxxx>
>>>
>>> please provide a proper From: and Signed-off-by line with full name.
>>>
>>> Regards
>>>
>>> Marcel
>>
>> Hi,
>>
>>
>> Update the patch From: and Signed-off-by: as follows:
>>
>> Jupeng Zhong <zhongjupeng@xxxxxxxxxx>
>
>
> Hi,
>
> Thanks to Markus Elfring for the suggestion:
>
> 1. add the tag “Fixes”.
> 2. omit the labels “err_out” and “err_free_skb” in this function
> implementation.
>
> The patch has been updated, please check.
>
> Thanks.
> <0001-Bluetooth-btusb-Fix-memory-leak-in-btusb_mtk_wmt_rec.patch>

please send patch inline via git-send-email or similar so that they are easy to review.

Regards

Marcel