[PATCH] fault_inject: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

From: Jiapeng Chong
Date: Mon Feb 01 2021 - 02:44:28 EST


Fix the following coccicheck warning:

./lib/fault-inject.c:187:0-23: WARNING: fops_stacktrace_depth should be
defined with DEFINE_DEBUGFS_ATTRIBUTE.

./lib/fault-inject.c:169:0-23: WARNING: fops_ul should be defined with
DEFINE_DEBUGFS_ATTRIBUTE.

Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
---
lib/fault-inject.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/fault-inject.c b/lib/fault-inject.c
index ce12621..cb7ea22 100644
--- a/lib/fault-inject.c
+++ b/lib/fault-inject.c
@@ -166,7 +166,7 @@ static int debugfs_ul_get(void *data, u64 *val)
return 0;
}

-DEFINE_SIMPLE_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n");

static void debugfs_create_ul(const char *name, umode_t mode,
struct dentry *parent, unsigned long *value)
@@ -184,8 +184,8 @@ static int debugfs_stacktrace_depth_set(void *data, u64 val)
return 0;
}

-DEFINE_SIMPLE_ATTRIBUTE(fops_stacktrace_depth, debugfs_ul_get,
- debugfs_stacktrace_depth_set, "%llu\n");
+DEFINE_DEBUGFS_ATTRIBUTE(fops_stacktrace_depth, debugfs_ul_get,
+ debugfs_stacktrace_depth_set, "%llu\n");

static void debugfs_create_stacktrace_depth(const char *name, umode_t mode,
struct dentry *parent,
--
1.8.3.1