[PATCH] checkpatch: add warning for line space after "Fixes:" tag

From: Shradha Todi
Date: Thu Jan 28 2021 - 11:04:52 EST


Add a check to give warning for line break between Fixes tag
and signature tags as that is the commonly followed style.

Also add a --fix option to delete space lines after "Fixes:" tag.

Signed-off-by: Lakshay Mehra <l.mehra@xxxxxxxxxxx>
Signed-off-by: Shradha Todi <shradha.t@xxxxxxxxxxx>
---
scripts/checkpatch.pl | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 92e888e..6c144c5 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3027,6 +3027,15 @@ sub process {
$commit_log_long_line = 1;
}

+# Check for no line break after Fixes
+ if ($line =~ /^\s*Fixes:/i && $rawlines[$linenr] =~ /^\s*$/) {
+ if (WARN("UNNECESSARY_NEWLINE",
+ "Newline is not required after Fixes:\n" . $herecurr) &&
+ $fix) {
+ fix_delete_line($fixlinenr+1, $rawline);
+ }
+ }
+
# Reset possible stack dump if a blank line is found
if ($in_commit_log && $commit_log_possible_stack_dump &&
$line =~ /^\s*$/) {
--
2.7.4