Re: [PATCH -next] usb: core: Remove unused including <linux/version.h>

From: Greg KH
Date: Tue Jan 26 2021 - 19:33:38 EST


On Mon, Jan 25, 2021 at 08:44:48PM +0800, Zou Wei wrote:
> Fix the following versioncheck warning:
>
> drivers/usb/core/hcd.c:14:1: unused including <linux/version.h>
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx>
> ---
> drivers/usb/core/hcd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
> index 3f03813..53bc93d 100644
> --- a/drivers/usb/core/hcd.c
> +++ b/drivers/usb/core/hcd.c
> @@ -11,7 +11,6 @@
>
> #include <linux/bcd.h>
> #include <linux/module.h>
> -#include <linux/version.h>
> #include <linux/kernel.h>
> #include <linux/sched/task_stack.h>
> #include <linux/slab.h>

You didn't test this patch, why???

{sigh}

greg k-h