Re: [PATCH v2 1/5] drm/panel-simple: Undo enable if HPD never asserts

From: Stephen Boyd
Date: Fri Jan 15 2021 - 17:50:29 EST


Quoting Douglas Anderson (2021-01-15 14:44:16)
> If the HPD signal never asserts in panel_simple_prepare() and we
> return an error, we should unset the enable GPIO and disable the
> regulator to make it consistent for the caller.
>
> At the moment I have some hardware where HPD sometimes doesn't assert.
> Obviously that needs to be debugged, but this patch makes it so that
> if I add a retry that I can make things work.
>
> Fixes: 48834e6084f1 ("drm/panel-simple: Support hpd-gpios for delaying prepare()")
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> ---

Nice catch on the unprepared_time

Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>