Re: [PATCH] mips: vdso: fix DWARF2 warning

From: Fangrui Song
Date: Fri Jan 15 2021 - 15:14:36 EST



On 2021-01-15, Anders Roxell wrote:
On Fri, 15 Jan 2021 at 20:28, Nathan Chancellor
<natechancellor@xxxxxxxxx> wrote:

On Fri, Jan 15, 2021 at 08:13:30PM +0100, Anders Roxell wrote:
> When building mips tinyconifg the following warning show up
>
> make --silent --keep-going --jobs=8 O=/home/anders/src/kernel/next/out/builddir ARCH=mips CROSS_COMPILE=mips-linux-gnu- HOSTCC=clang CC=clang
> /srv/src/kernel/next/arch/mips/vdso/elf.S:14:1: warning: DWARF2 only supports one section per compilation unit
> .pushsection .note.Linux, "a",@note ; .balign 4 ; .long 2f - 1f ; .long 4484f - 3f ; .long 0 ; 1:.asciz "Linux" ; 2:.balign 4 ; 3:
> ^
> /srv/src/kernel/next/arch/mips/vdso/elf.S:34:2: warning: DWARF2 only supports one section per compilation unit
> .section .mips_abiflags, "a"
> ^
>
> Rework so the mips vdso Makefile adds flag '-no-integrated-as' unless
> LLVM_IAS is defined.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/1256
> Cc: stable@xxxxxxxxxxxxxxx # v4.19+
> Suggested-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>

I believe this is the better solution:

https://lore.kernel.org/r/20210115192622.3828545-1-natechancellor@xxxxxxxxx/

Yes, I agree.

Cheers,
Anders

http://lore.kernel.org/r/20201202010850.jibrjpyu6xgkff5p@xxxxxxxxxx
Personally I'd drop DWARF v2 as an option.