Re: [f2fs-dev] [PATCH v2 1/2] f2fs: introduce checkpoint=merge mount option

From: Chao Yu
Date: Fri Jan 15 2021 - 09:34:37 EST


On 2021/1/15 22:00, Daeho Jeong wrote:
ktime_get() returns time based ns unit, in extreme scenario, average
time cp cost will overflow 32-bit variable, I doubt.

sum_diff is already turned into msec using ktime_ms_delta() above.

Yup, I missed ktime_ms_delta().


On 2021/1/15 22:23, Daeho Jeong wrote:
>>> How about updating queued_ckpt and total_ckpt in batch, update atomic
>>> variable one by one is low efficient.
>>>
>> You mean like using spin_lock()?
>>
> Ah, you mean like updating these values as much as the count of the
> loop at once?

Correct. :)

Thanks,