Re: [PATCH v3 15/15] kasan: don't run tests when KASAN is not enabled

[Marco Elver]

On Thu, Jan 14, 2021 at 08:36PM +0100, Andrey Konovalov wrote:
> Don't run KASAN tests when it's disabled with kasan.mode=off to avoid
> corrupting kernel memory.
> 
> Link: https://linux-review.googlesource.com/id/I6447af436a69a94bfc35477f6bf4e2122948355e
> Signed-off-by: Andrey Konovalov <andreyknvl@xxxxxxxxxx>

Reviewed-by: Marco Elver <elver@xxxxxxxxxx>

> ---
>  lib/test_kasan.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/lib/test_kasan.c b/lib/test_kasan.c
> index a96376aa7293..6238b56127f8 100644
> --- a/lib/test_kasan.c
> +++ b/lib/test_kasan.c
> @@ -47,6 +47,11 @@ static bool multishot;
>   */
>  static int kasan_test_init(struct kunit *test)
>  {
> +	if (!kasan_enabled()) {
> +		kunit_err(test, "can't run KASAN tests with KASAN disabled");
> +		return -1;
> +	}
> +
>  	multishot = kasan_save_enable_multi_shot();
>  	hw_set_tagging_report_once(false);
>  	return 0;
> -- 
> 2.30.0.284.gd98b1dd5eaa7-goog
>