Re: [PATCH v4 1/1] mfd: intel-m10-bmc: expose mac address and count

From: Lee Jones
Date: Fri Jan 15 2021 - 02:39:09 EST


On Thu, 14 Jan 2021, Russ Weight wrote:

> Create two sysfs entries for exposing the MAC address
> and count from the MAX10 BMC register space. The MAC
> address is the first in a sequential block of MAC addresses
> reserved for the FPGA card. The MAC count is the number
> of MAC addresses in the reserved block.
>
> Signed-off-by: Russ Weight <russell.h.weight@xxxxxxxxx>
> Signed-off-by: Xu Yilun <yilun.xu@xxxxxxxxx>
> ---
> v4:
> - Changed local variables macaddr1 and macaddr2 to macaddr_low
> and macaddr_high
> - Change macros M10BMC_MACADDR1 and M10BMC_MACADDR2 to
> M10BMC_MAC_LOW and M10BMC_MAC_HIGH
> v3:
> - Updated Date and KernelVersion in ABI documentation
> v2:
> - Updated the documentation for the mac_address and mac_count
> sysfs nodes to clarify their usage.
> - Changed sysfs _show() functions to use sysfs_emit() instead
> of sprintf.
> ---
> .../ABI/testing/sysfs-driver-intel-m10-bmc | 21 +++++++++
> drivers/mfd/intel-m10-bmc.c | 43 +++++++++++++++++++
> include/linux/mfd/intel-m10-bmc.h | 9 ++++
> 3 files changed, 73 insertions(+)

Changed the subject line to start with an uppercase char and used more
width in the commit message and applied, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog