Re: [PATCH v2 3/4] kunit: tool: use `with open()` in unit test

From: Brendan Higgins
Date: Thu Jan 14 2021 - 17:20:51 EST


On Wed, Dec 2, 2020 at 11:09 AM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote:
>
> The use of manual open() and .close() calls seems to be an attempt to
> keep the contents in scope.
> But Python doesn't restrict variables like that, so we can introduce new
> variables inside of a `with` and use them outside.
>
> Do so to make the code more Pythonic.
>
> Signed-off-by: Daniel Latypov <dlatypov@xxxxxxxxxx>

Tested-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
Acked-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>