Re: [PATCH] x86/mm/mtrr: remove definition of DEBUG

From: Borislav Petkov
Date: Thu Jan 14 2021 - 13:47:25 EST


On Thu, Jan 14, 2021 at 08:27:43AM -0800, trix@xxxxxxxxxx wrote:
> From: Tom Rix <trix@xxxxxxxxxx>
>
> Defining DEBUG should only be done in development.
> So remove DEBUG.
>
> Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> ---
> arch/x86/kernel/cpu/mtrr/generic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c
> index a29997e6cf9e..b90f3f437765 100644
> --- a/arch/x86/kernel/cpu/mtrr/generic.c
> +++ b/arch/x86/kernel/cpu/mtrr/generic.c
> @@ -3,7 +3,6 @@
> * This only handles 32bit MTRR on 32bit hosts. This is strictly wrong
> * because MTRRs can span up to 40 bits (36bits on most modern x86)
> */
> -#define DEBUG
>
> #include <linux/export.h>
> #include <linux/init.h>

Wanna merge all 4 in arch/x86/

arch/x86/kernel/cpu/mtrr/generic.c:6:#define DEBUG
arch/x86/kernel/cpu/mtrr/mtrr.c:34:#define DEBUG
arch/x86/kernel/pci-iommu_table.c:8:#define DEBUG 1
arch/x86/mm/mmio-mod.c:13:#define DEBUG 1

into a single patch?

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette