Re: [PATCH 21/30] drm/amd/display/dc/core/dc_resource: Demote some kernel-doc abuses

From: Alex Deucher
Date: Thu Jan 14 2021 - 12:23:40 EST


On Wed, Jan 13, 2021 at 3:08 AM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1710: warning: Function parameter or member 'old_stream' not described in 'dc_is_stream_unchanged'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1710: warning: Function parameter or member 'stream' not described in 'dc_is_stream_unchanged'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1726: warning: Function parameter or member 'old_stream' not described in 'dc_is_stream_scaling_unchanged'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1726: warning: Function parameter or member 'stream' not described in 'dc_is_stream_scaling_unchanged'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1843: warning: Function parameter or member 'dc' not described in 'dc_add_stream_to_ctx'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1843: warning: Function parameter or member 'new_ctx' not described in 'dc_add_stream_to_ctx'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1843: warning: Function parameter or member 'stream' not described in 'dc_add_stream_to_ctx'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1870: warning: Function parameter or member 'dc' not described in 'dc_remove_stream_from_ctx'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1870: warning: Function parameter or member 'new_ctx' not described in 'dc_remove_stream_from_ctx'
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1870: warning: Function parameter or member 'stream' not described in 'dc_remove_stream_from_ctx'
>
> Cc: Harry Wentland <harry.wentland@xxxxxxx>
> Cc: Leo Li <sunpeng.li@xxxxxxx>
> Cc: Alex Deucher <alexander.deucher@xxxxxxx>
> Cc: "Christian König" <christian.koenig@xxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Applied. Thanks!

Alex

> ---
> drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> index d423092c45dcd..185412d0c1429 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
> @@ -1697,7 +1697,7 @@ static bool are_stream_backends_same(
> return true;
> }
>
> -/**
> +/*
> * dc_is_stream_unchanged() - Compare two stream states for equivalence.
> *
> * Checks if there a difference between the two states
> @@ -1718,7 +1718,7 @@ bool dc_is_stream_unchanged(
> return true;
> }
>
> -/**
> +/*
> * dc_is_stream_scaling_unchanged() - Compare scaling rectangles of two streams.
> */
> bool dc_is_stream_scaling_unchanged(
> @@ -1833,7 +1833,7 @@ static struct audio *find_first_free_audio(
> return 0;
> }
>
> -/**
> +/*
> * dc_add_stream_to_ctx() - Add a new dc_stream_state to a dc_state.
> */
> enum dc_status dc_add_stream_to_ctx(
> @@ -1860,7 +1860,7 @@ enum dc_status dc_add_stream_to_ctx(
> return res;
> }
>
> -/**
> +/*
> * dc_remove_stream_from_ctx() - Remove a stream from a dc_state.
> */
> enum dc_status dc_remove_stream_from_ctx(
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel