Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe

From: Menglong Dong
Date: Thu Jan 14 2021 - 09:55:03 EST


On Thu, Jan 14, 2021 at 4:30 PM Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxx> wrote:
[...]
> >
> > What does this 'MBR' mean? I am a novice~~~
>
> Generally speaking, Master Boot Record. But I also use it to send you My
> Best Regards. :-)

Haha~,

> > So, is it better to replace 'platform_get_irq' with
> > 'platform_get_irq_optional' here?
>
> No. You should stop overriding the result to -ENOENT and pass the result
> up the call chain instead. In order to do it, you should only check for (irq < 0).

Well, I didn't even notice this. It does seem to be another problem...

---
Best Regards
Menglong Dong