Re: [PATCH RFC 3/3] ipmi: remove open coded version of SMBus block write

From: Wolfram Sang
Date: Thu Jan 14 2021 - 09:05:10 EST



> I asked the original authors of this about the change, and apparently is
> results in a stack size warning. Arnd Bergmann ask for it to be changed
> from what you are suggesting to what it currently is. See:
>
> https://www.lkml.org/lkml/2019/6/19/440
>
> So apparently this change will cause compile warnings due to the size of
> struct i2c_client.

Wow, didn't know that my patch was actually a revert. I replaced now the
stack usage with kmemdup and will have a second thought about this
patch. Thanks for the heads up!

Attachment: signature.asc
Description: PGP signature