Re: [PATCH v2 1/2] perf tools: add 'perf irq' to measure the hardware interrupts

From: Alexei Budankov
Date: Thu Jan 14 2021 - 04:33:02 EST



On 14.01.2021 10:48, Bixuan Cui wrote:
> Add 'perf irq' to trace/measure the hardware interrupts.
>
> Now three functions are provided:
> 1. 'perf irq record <command>' to record the irq handler events.
> 2. 'perf irq script' to see a detailed trace of the workload that
> was recorded.
> 3. 'perf irq report' to calculate the time consumed by each
> hardware interrupt processing function.
>
> Signed-off-by: Bixuan Cui <cuibixuan@xxxxxxxxxx>
> ---
> tools/perf/Build | 1 +
> tools/perf/builtin-irq.c | 287 +++++++++++++++++++++++++++++++++++++++
> tools/perf/builtin.h | 1 +
> tools/perf/perf.c | 1 +
> 4 files changed, 290 insertions(+)
> create mode 100644 tools/perf/builtin-irq.c

<SNIP>

> +static int __cmd_record(int argc, const char **argv)
> +{
> + unsigned int rec_argc, i, j;
> + const char **rec_argv;
> + const char * const record_args[] = {
> + "record",
> + "-a",

Could you please make it configurable from the command line
jointly with -p option?

> + "-R",
> + "-c", "1",
> + "-e", "irq:irq_handler_entry",
> + "-e", "irq:irq_handler_exit",
> + };

Thanks,
Alexei