Re: [PATCH net] net: stmmac: use __napi_schedule() for PREEMPT_RT

From: Jakub Kicinski
Date: Wed Jan 13 2021 - 20:51:36 EST


On Tue, 12 Jan 2021 15:01:22 +0100 Sebastien Laveze wrote:
> From: Seb Laveze <sebastien.laveze@xxxxxxx>
>
> Use of __napi_schedule_irqoff() is not safe with PREEMPT_RT in which
> hard interrupts are not disabled while running the threaded interrupt.
>
> Using __napi_schedule() works for both PREEMPT_RT and mainline Linux,
> just at the cost of an additional check if interrupts are disabled for
> mainline (since they are already disabled).
>
> Similar to the fix done for enetc:
> 215602a8d212 ("enetc: use napi_schedule to be compatible with PREEMPT_RT")
>
> Signed-off-by: Seb Laveze <sebastien.laveze@xxxxxxx>

Fixed up the commit message to appease checkpatch and applied, thanks!