Re: [PATCH] nt: usb: USB_RTL8153_ECM should not default to y

[Greg KH]

On Wed, Jan 13, 2021 at 03:43:09PM +0100, Geert Uytterhoeven wrote:
> In general, device drivers should not be enabled by default.
> 
> Fixes: 657bc1d10bfc23ac ("r8153_ecm: avoid to be prior to r8152 driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
>  drivers/net/usb/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> index 1e37190287808973..fbbe786436319013 100644
> --- a/drivers/net/usb/Kconfig
> +++ b/drivers/net/usb/Kconfig
> @@ -631,7 +631,6 @@ config USB_NET_AQC111
>  config USB_RTL8153_ECM
>  	tristate "RTL8153 ECM support"
>  	depends on USB_NET_CDCETHER && (USB_RTL8152 || USB_RTL8152=n)
> -	default y
>  	help
>  	  This option supports ECM mode for RTL8153 ethernet adapter, when
>  	  CONFIG_USB_RTL8152 is not set, or the RTL8153 device is not

Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>