Re: [External] Re: [PATCH v4 4/6] mm: hugetlb: retry dissolve page when hitting race

From: Muchun Song
Date: Wed Jan 13 2021 - 06:21:38 EST


On Wed, Jan 13, 2021 at 7:15 PM Oscar Salvador <osalvador@xxxxxxx> wrote:
>
> On Wed, Jan 13, 2021 at 07:11:06PM +0800, Muchun Song wrote:
> > If there is no task to be scheduled. Here is just a while loop.
> > The cpu_relax is a good thing to insert into busy-wait loops,
> > right?
>
> But if the race window is that small, does it make sense?

Actually, there is one exception. The race window could
become larger. If the page is freed via a workqueue (see
free_huge_page()). In this case, the cpu_relax() can
make sense. Right?

>
> --
> Oscar Salvador
> SUSE L3