Re: [PATCH v7 3/7] mfd: Add base driver for Netronix embedded controller

[Lee Jones]

On Tue, 12 Jan 2021, Andreas Kemnade wrote:

> On Sat,  9 Jan 2021 19:02:16 +0100
> Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> wrote:
> 
> > The Netronix embedded controller is a microcontroller found in some
> > e-book readers designed by the original design manufacturer Netronix,
> > Inc. It contains RTC, battery monitoring, system power management, and
> > PWM functionality.
> > 
> > This driver implements register access and version detection.
> > 
> > Third-party hardware documentation is available at:
> > 
> >   https://github.com/neuschaefer/linux/wiki/Netronix-MSP430-embedded-controller
> > 
> > The EC supports interrupts, but the driver doesn't make use of them so
> > far.
> > 
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
> > Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>

[...]

> > +static const struct of_device_id of_ntxec_match_table[] = {
> > +	{ .compatible = "netronix,ntxec", },
> > +	{}
> > +};
> > +
> MODULE_DEVICE_TABLE?
> 
> > +static struct i2c_driver ntxec_driver = {
> > +	.driver = {
> > +		.name = "ntxec",
> > +		.of_match_table = of_ntxec_match_table,
> > +	},
> > +	.probe_new = ntxec_probe,
> > +	.remove = ntxec_remove,
> > +};
> > +module_i2c_driver(ntxec_driver);
> 
> MODULE_LICENSE()?
> 
> modpost moans about that here.

Andreas, would you be kind enough to snip/trim your replies in future
please.  It would save a *lot* of people a little bit of time (which
adds up fast).  TIA.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog