Re: [PATCH V4 1/3] dt-bindings: phy: brcm, brcmstb-usb-phy: convert to the json-schema

From: Rob Herring
Date: Tue Jan 12 2021 - 22:18:23 EST


On Wed, 06 Jan 2021 21:58:36 +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@xxxxxxxxxx>
>
> Changes that require mentioning:
> 1. interrupt-names
> Name "wakeup" was changed to the "wake". It matches example and what
> Linux driver looks for in the first place
> 2. brcm,ipp and brcm,ioc
> Both were described as booleans with 0 / 1 values. In examples they
> were integers and Linux checks for int as well. Both got uint32.
> 3. Added minimal description
>
> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
> ---
> V2: Add Al as maintainer
> V3: Define "reg" and "reg-names" directly in the properties
> V4: additionalProperties: false
> Fix example to use brcm,syscon-piarbctl (with the prefix)
> ---
> .../bindings/phy/brcm,brcmstb-usb-phy.txt | 86 --------
> .../bindings/phy/brcm,brcmstb-usb-phy.yaml | 193 ++++++++++++++++++
> 2 files changed, 193 insertions(+), 86 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt
> create mode 100644 Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>