RE: [PATCH 4.14 147/242] scsi: fnic: Fix error return code in fnic_probe()

[Karan Tilak Kumar (kartilak)]

Acked-by: Karan Tilak Kumar <kartilak@xxxxxxxxx>

Regards,
Karan

-----Original Message-----
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> 
Sent: Monday, December 28, 2020 4:49 AM
To: linux-kernel@xxxxxxxxxxxxxxx
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; stable@xxxxxxxxxxxxxxx; Hulk Robot <hulkci@xxxxxxxxxx>; Karan Tilak Kumar (kartilak) <kartilak@xxxxxxxxx>; Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>; Martin K. Petersen <martin.petersen@xxxxxxxxxx>; Sasha Levin <sashal@xxxxxxxxxx>
Subject: [PATCH 4.14 147/242] scsi: fnic: Fix error return code in fnic_probe()

From: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>

[ Upstream commit d4fc94fe65578738ded138e9fce043db6bfc3241 ]

Return a negative error code from the error handling case instead of 0 as done elsewhere in this function.

Link: https://lore.kernel.org/r/1607068060-31203-1-git-send-email-zhangchangzhong@xxxxxxxxxx
Fixes: 5df6d737dd4b ("[SCSI] fnic: Add new Cisco PCI-Express FCoE HBA")
Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Reviewed-by: Karan Tilak Kumar <kartilak@xxxxxxxxx>
Signed-off-by: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>
Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
---
 drivers/scsi/fnic/fnic_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c index aacadbf20b695..878e486762729 100644
--- a/drivers/scsi/fnic/fnic_main.c
+++ b/drivers/scsi/fnic/fnic_main.c
@@ -746,6 +746,7 @@ static int fnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	for (i = 0; i < FNIC_IO_LOCKS; i++)
 		spin_lock_init(&fnic->io_req_lock[i]);
 
+	err = -ENOMEM;
 	fnic->io_req_pool = mempool_create_slab_pool(2, fnic_io_req_cache);
 	if (!fnic->io_req_pool)
 		goto err_out_free_resources;
--
2.27.0