Re: mmotm 2021-01-12-01-57 uploaded (NR_SWAPCACHE in mm/)

[Randy Dunlap]

On 1/12/21 1:50 PM, Andrew Morton wrote:

>>
>> on i386 and x86_64:
>>
>> when CONFIG_SWAP is not set/enabled:
>>
>> ../mm/migrate.c: In function ‘migrate_page_move_mapping’:
>> ../mm/migrate.c:504:35: error: ‘NR_SWAPCACHE’ undeclared (first use in this function); did you mean ‘QC_SPACE’?
>>     __mod_lruvec_state(old_lruvec, NR_SWAPCACHE, -nr);
>>                                    ^~~~~~~~~~~~
>>
>> ../mm/memcontrol.c:1529:20: error: ‘NR_SWAPCACHE’ undeclared here (not in a function); did you mean ‘SGP_CACHE’?
>>   { "swapcached",   NR_SWAPCACHE   },
>>                     ^~~~~~~~~~~~
> 
> Thanks.  I did the below.

WorsForMe. Thanks.

Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>


> But we're still emitting "Node %d SwapCached: 0 kB" in sysfs when
> CONFIG_SWAP=n, which is probably wrong.  Shakeel, can you please have a
> think?

-- 
~Randy
You can't do anything without having to do something else first.
-- Belefant's Law