Re: [Sound-open-firmware] [PATCH] ASoC: SOF: Intel: avoid reverse module dependency

From: Pierre-Louis Bossart
Date: Tue Jan 12 2021 - 16:58:28 EST



Since this is going to be a really invasive change, and past
experience shows that mucking with Kconfigs will invariably raise a
number of broken corner cases, if there is support from
Mark/Takashi/Jaroslav on this idea, we should first test it in the SOF
tree so that we get a good test coverage and don't break too many eggs
in Mark's tree. We would also need to concurrently change our CI
scripts which are dependent on module names.

I'm in favor of the way Arnd proposed. It's more straightforward and
less code.

Thanks Takashi for the feedback.

Since yesterday I looked at another problem where we can have unmet dependencies between SoundWire (m) and SOF (y), so we probably need to rethink all this. We had similar issue with SOF and HDaudio before, it's time to revisit all this.


If you find the number of modules or the too much cutting out being
problematic, you can create a module snd-sof-intel-acpi and
snd-sof-intel-pci containing the driver table entries for all Intel
devices, too. In the case, you'll still need some conditional calls
of intel-dsp-config there, but it's a good step for reducing the
Kconfig complexity.

Also maybe in a first pass we can remove the compilation error with
IS_REACHABLE and in a second pass do more invasive surgery?

Agreed, we'd like to keep less changes for 5.11 for now.

Ack, we'll send smaller changes first.