Re: [PATCH 1/2] init/main.c: fix strings split across lines

[Liu Peibao]

On 1/12/21 8:02 AM, Steven Rostedt wrote:
> On Wed, 30 Dec 2020 14:04:23 +0800
> Liu Peibao <liupeibao@xxxxxxx> wrote:
>
> > Fix warning found by checkpatch.pl.
> >
> > Signed-off-by: Liu Peibao <liupeibao@xxxxxxx>
> > ---
> >   init/main.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/init/main.c b/init/main.c
> > index 6feee7f11eaf..1e492de770c8 100644
> > --- a/init/main.c
> > +++ b/init/main.c
> > @@ -1470,8 +1470,7 @@ static int __ref kernel_init(void *unused)
> >   	    !try_to_run_init_process("/bin/sh"))
> >   		return 0;
> >   
> > -	panic("No working init found.  Try passing init= option to kernel. "
> > -	      "See Linux Documentation/admin-guide/init.rst for guidance.");
> > +	panic("No working init found. Try passing init= option to kernel. See Linux Documentation/admin-guide/init.rst for guidance.");
>
> Sorry, we don't add changes to the kernel that checkpatch warns about.
> checkpatch should only be run on new code. Please do not submit any patches
> on existing code because checkpatch warns about it.
>
> -- Steve
Thanks for your replay! I get it.
But I still feel a little confused that we use different standard to 
measure the existing code and the new code. I also checked some commits, 
there are similar patches too.

BR,
Peibao
> >   }
> >   
> >   /* Open /dev/console, for stdin/stdout/stderr, this should never fail */