Re: [PATCH v2 08/70] mm/mmap: Change find_vma() to use the maple tree

[Randy Dunlap]

Hi,
Please adjust the kernel-doc to be correct :)

On 1/12/21 8:11 AM, Liam R. Howlett wrote:
> Start using the maple tree to find VMA entries in an mm_struct.
> 
> Signed-off-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
> ---
>  mm/mmap.c | 29 +++++++++++------------------
>  1 file changed, 11 insertions(+), 18 deletions(-)
> 
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 65789b188c380..ab1cb0efc4c65 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2474,10 +2474,17 @@ get_unmapped_area(struct file *file, unsigned long addr, unsigned long len,
>  
>  EXPORT_SYMBOL(get_unmapped_area);
>  
> -/* Look up the first VMA which satisfies  addr < vm_end,  NULL if none. */
> +/**
> + * find_vma() - Find the VMA for a given address, or the next vma.  May return
> + * NULL in the case of no vma at addr or above

      %NULL

> + * @mm The mm_struct to check

    * @mm: ...

> + * @addr: The address
> + *
> + * Returns: The VMA assoicated with addr, or the next vma.

                       associated

> + * May return NULL in the case of no vma at addr or above.

                 %NULL

> + */
>  struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
>  {


thanks.
-- 
~Randy