Re: [PATCH RFC 2/3] media: i2c: adv7842: remove open coded version of SMBus block read

From: Wolfram Sang
Date: Tue Jan 12 2021 - 14:42:41 EST



> +static int adv7511_edid_rd(struct v4l2_subdev *sd, uint16_t len, uint8_t *buf)
> {
> struct adv7511_state *state = get_adv7511_state(sd);
> + s32 len;

And 'len' here shadows the function argument :( Ok, I need to resend
this patch. Still, looking forward to a comment if an approach like this
is acceptable.

Attachment: signature.asc
Description: PGP signature