Re: [PATCH v2] blk: avoid divide-by-zero with zero granularity

[Martin K. Petersen]

Johannes,

>> I use the nvme-tcp as the host, the target is spdk nvme-tcp target,
>> and set a wrong block size(i.g. bs=8), then the host prints this oops:
>
> I think the better fix here is to reject devices which report a block size
> small than a sector.

Yep, Linux doesn't support logical block sizes < 512 bytes.

Also, the NVMe spec states:

	"A value smaller than 9 (i.e., 512 bytes) is not supported."

-- 
Martin K. Petersen	Oracle Linux Engineering