Re: [PATCH v2] i2c: tegra: Create i2c_writesl_vi() to use with VI I2C for filling TX FIFO
From: Dmitry Osipenko
Date: Tue Jan 12 2021 - 12:35:22 EST
12.01.2021 19:57, Sowjanya Komatineni пишет:
...
>> @@ -326,6 +326,8 @@ static void i2c_writel(struct tegra_i2c_dev
>> *i2c_dev, u32 val, unsigned int reg)
>> /* read back register to make sure that register writes
>> completed */
>> if (reg != I2C_TX_FIFO)
>> readl_relaxed(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev,
>> reg));
>> + else
>> + readl_relaxed(i2c_dev->base + tegra_i2c_reg_addr(i2c_dev,
>> I2C_INT_STATUS));
>
Perhaps will be a bit better to replace this "else" with "else if
(i2c_dev->is_vi)".