Re: [PATCH v11 5/7] dt-bindings: soc: mediatek: add mt8192 svs dt-bindings

From: Rob Herring
Date: Tue Jan 12 2021 - 09:49:26 EST


On Thu, Jan 07, 2021 at 10:43:54AM +0800, Roger Lu wrote:
> Signed-off-by: Roger Lu <roger.lu@xxxxxxxxxxxx>
> ---
> .../devicetree/bindings/soc/mediatek/mtk-svs.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml b/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml
> index bb8c345a0c0a..2e61b07921aa 100644
> --- a/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mtk-svs.yaml
> @@ -22,6 +22,7 @@ properties:
> compatible:
> enum:
> - mediatek,mt8183-svs
> + - mediatek,mt8192-svs
>
> reg:
> description: Address range of the MTK SVS controller.
> @@ -47,6 +48,14 @@ properties:
> - const: svs-calibration-data
> - const: t-calibration-data
>
> + resets:
> + description:
> + svs reset control.

How many?

And you can drop the description given there's only 1.

> +
> + reset-names:
> + items:
> + - const: svs_rst
> +
> required:
> - compatible
> - reg
> --
> 2.18.0
>