Re: [PATCH v5 0/3] AMS, Collision Avoidance, and Protocol Error

From: Heikki Krogerus
Date: Tue Jan 12 2021 - 07:01:04 EST


On Tue, Jan 12, 2021 at 12:53:56PM +0100, Greg KH wrote:
> On Wed, Jan 06, 2021 at 12:39:24AM +0800, Kyle Tso wrote:
> > This series include previous patch "[v4] AMS and Collision Avoidance"
> > https://lore.kernel.org/r/20201217030632.903718-1-kyletso@xxxxxxxxxx
> > and two more patches "Protocol Error handling" and "Respond Wait if...".
> >
> > The patch "AMS and Collision Avoidance" in [v5] is the same as the one
> > in [v4] (only rebased to ToT).
> >
> > The patch "Protocol Error handling" is based on PD3 6.8.1 to fix the
> > wrong handling.
> >
> > The patch "Respond Wait if..." is to fix a conflict when
> > DR/PR/VCONN_SWAP occurs just after the state machine enters Ready State.
> >
> > Kyle Tso (3):
> > usb: typec: tcpm: AMS and Collision Avoidance
> > usb: typec: tcpm: Protocol Error handling
> > usb: typec: tcpm: Respond Wait if VDM state machine is running
> >
> > drivers/usb/typec/tcpm/tcpm.c | 925 +++++++++++++++++++++++++++++-----
> > include/linux/usb/pd.h | 2 +
> > include/linux/usb/tcpm.h | 4 +
> > 3 files changed, 792 insertions(+), 139 deletions(-)
>
> Heikki, any thoughts about this series?

Sorry, I did yet go over these yet. I'll review them now.

Guenter, have you had time to take a look at these?

Br,

--
heikki