Re: [PATCH v2] i2c: tegra-bpmp: ignore DMA safe buffer flag

From: Mikko Perttunen
Date: Tue Jan 12 2021 - 05:28:01 EST


On 1/12/21 12:26 PM, Wolfram Sang wrote:

I wonder if bailing out on an unknown flag shouldn't be revisited in
general? I mean this will happen again when a new I2C_M_* flag is
introduced.


If it's guaranteed that any new flags are optional to handle by the driver,
than that is certainly better. I'll post a v3 with that approach.

If there will be a new flag, it is highly likely that it will handle
some corner case which only gets applied when there is a I2C_FUNC_* flag
guarding it. If the new flag turns out to be mandatory, the (poor)
author needs to check with all existing drivers anyhow.


Yep, I suppose that is true :)

I just sent out the v3.

thanks!
Mikko