Re: [PATCH v7,2/2] dt: bindings: add silabs,si4455 schema

[József Horváth]

On Mon, Jan 11, 2021 at 05:30:48PM -0600, Rob Herring wrote:
> On Tue, Jan 05, 2021 at 10:30:29AM +0000, József Horváth wrote:
> > This is a device tree schema for serial port driver for
> >  Silicon Labs Si4455 Sub-GHz transciver.
> > 
> > Datasheet: https://www.silabs.com/documents/public/data-sheets/Si4455.pdf
> > 
> > Guide: https://github.com/dministro/linux-serial-si4455
> > 
> > Signed-off-by: Jozsef Horvath <info@xxxxxxxxxxx>
> > ---
> > 
> > changes v1:
> >  - fixed: dt: bindings: rename sdn-gpios to shutdown-gpios
> > 
> > changes v3:
> >  - fixed: dt: bindings: silabs,si4455: more detailed description
> >  - added: dt: bindings: silabs,si4455: properties silabs,package-size,
> >    silabs,tx-channel, silabs,rx-channel, silabs,ez-config
> > 
> > changes v4:
> >  - fixed: dt: bindings: silabs,si4455: $id
> >    from http://devicetree.org/schemas/serial/silabs,si4455.yaml
> >    to http://devicetree.org/schemas/staging/serial/silabs,si4455.yaml
> > 
> > changes v5:
> >  - fixed: dt: bindings: silabs,si4455: $id
> >    from http://devicetree.org/schemas/staging/serial/silabs,si4455.yaml
> >    to http://devicetree.org/schemas/serial/silabs,si4455.yaml
> >  - fixed: dt: bindings: silabs,si4455: serial.yaml reference added
> > 
> > changes v7:
> >  - added: dt: bindings: silabs,si4455: silabs,tx-timeout property definition
> > ---
> >  .../bindings/serial/silabs,si4455.yaml        | 105 ++++++++++++++++++
> >  1 file changed, 105 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/serial/silabs,si4455.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/serial/silabs,si4455.yaml b/Documentation/devicetree/bindings/serial/silabs,si4455.yaml
> > new file mode 100644
> > index 000000000000..8ba4956064b4
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/serial/silabs,si4455.yaml
> > @@ -0,0 +1,105 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/serial/silabs,si4455.yaml#";
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> > +
> > +title: Silicon Labs Si4455 device tree bindings
> > +
> > +  silabs,rx-channel:
> > +    description:
> > +      Radio receive channel selection.
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    maximum: 255
> > +    minimum: 0
> > +
> > +  silabs,tx-timeout:
> > +    description:
> > +      Radio transmit timeout(ms)
> 
> Use a unit suffix as defined in property-units.txt.
> 
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> 
> With that, you can drop the type.
>

Thank you for suggestion.
 
> > +    maximum: 1000
> > +    minimum: 1
> > +
> > +  firmware-name:
> > +    description:
> > +      Radio configuration data file name.
> > +    $ref: /schemas/types.yaml#/definitions/string
> > +    items:
> > +      pattern: ^[0-9a-z\._\-]{1,255}$
> > +
> > +    };
> > +...
> > -- 
> > 2.17.1
> > 

Üdvözlettel / Best regards:
József Horváth