Re: [PATCH V2] arch: x86: kernel: cpu: Takes a letter away and put a semicolon too, to match below stuc member

From: Randy Dunlap
Date: Tue Jan 12 2021 - 01:55:21 EST


On 1/11/21 9:27 PM, Bhaskar Chowdhury wrote:
> s/kernlfs/kernfs/
>
> A semicolon at the end of member name
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@xxxxxxxxx>
> ---
> As pointed out by Gustavo and Randy in version one of this patch
>
> arch/x86/kernel/cpu/resctrl/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index ee71c47844cb..ef9e2c0809b8 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -142,7 +142,7 @@ enum rdtgrp_mode {
>
> /**
> * struct mongroup - store mon group's data in resctrl fs.
> - * @mon_data_kn kernlfs node for the mon_data directory
> + * @mon_data_kn: kernfs node for the mon_data directory
> * @parent: parent rdtgrp
> * @crdtgrp_list: child rdtgroup node list
> * @rmid: rmid for this rdtgroup
> --

The patch to internal.h is OK, but as Gustavo pointed out,
the patch versioning isn't done as expected.

--
~Randy