Re: [PATCH 13/14] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102

From: Pierre-Louis Bossart
Date: Mon Jan 11 2021 - 15:30:25 EST



+ return ret;
+ }
+
+ ret = snd_soc_component_set_sysclk(codec_component, ARIZONA_CLK_OPCLK, 0,
+ rate * sr_mult, SND_SOC_CLOCK_OUT);
+ if (ret) {
+ dev_err(codec_component->dev, "Error setting OPCLK: %d\n", ret);
+ return ret;
+ }

OPCLK is a clock that can be outputted on the CODECs GPIOs. Is
that being used to clock some external component? If so it should
be added to the DAPM graph, if not you might as well remove this
call.

Thanks Charles for the feedback.

I have a vague recollection that the routing was supposed to be something like:

AP-----V
WM5102----> BT HFP
Modem--^

with processing on WM5102.

But when I look at the initial Android code there are references to the HFP path being handled by the AP.

Probably better to remove this clock configuration if the need for it is unclear, the goal is only to enable speaker/headset for now.