Re: [v3 PATCH 02/11] mm: vmscan: consolidate shrinker_maps handling code

From: Yang Shi
Date: Mon Jan 11 2021 - 14:01:13 EST


On Wed, Jan 6, 2021 at 4:14 PM Roman Gushchin <guro@xxxxxx> wrote:
>
> On Tue, Jan 05, 2021 at 02:58:08PM -0800, Yang Shi wrote:
> > The shrinker map management is not really memcg specific, it's just allocation
>
> In the current form it doesn't look so, especially because each name
> has a memcg_ prefix and each function takes a memcg argument.
>
> It begs for some refactorings (Kirill suggested some) and renamings.

BTW, do you mean the suggestion about renaming memcg_shrinker_maps to
shrinker_maps? I just saw his email today since gmail filtered his
emails to SPAM :-(

>
> Thanks!