Re: [PATCH 2/7] soc: qcom: geni: move struct geni_wrapper to header

From: Vinod Koul
Date: Mon Jan 11 2021 - 12:44:54 EST


On 11-01-21, 09:34, Bjorn Andersson wrote:
> On Mon 11 Jan 09:16 CST 2021, Vinod Koul wrote:
>
> > I2C geni driver needs to access struct geni_wrapper, so move it to
> > header.
> >
>
> Please tell me more!
>
> Glanced through the other patches and the only user I can find it in
> patch 5 where you use this to get the struct device * of the wrapper.

That is correct. The dma mapping needs to be done with SE device.

> At least in the DT case this would be [SE]->dev->parent, perhaps we
> can't rely on this due to ACPI?

I would have missed that then, but I somehow recall trying that.. Though
I have not looked into ACPI..

Given that we would need to worry about ACPI, do you recommend using
parent or keeping this

--
~Vinod