Re: [PATCH net-next 2/2] drivers: net: dsa: mt7530: MT7530 optional GPIO support

From: DENG Qingfang
Date: Mon Jan 11 2021 - 08:40:52 EST


On Mon, Jan 11, 2021 at 7:04 PM Russell King - ARM Linux admin
<linux@xxxxxxxxxxxxxxx> wrote:
>
> FYI, Documentation/driver-api/gpio/consumer.rst says:
>
> For output GPIOs, the value provided becomes the initial output value.
> This helps avoid signal glitching during system startup.
>
> Setting the pin to be an output, and then setting its initial value
> does not avoid the glitch. You may wish to investigate whether you
> can set the value before setting the pin as an output to avoid this
> issue.
>

So, setting the Output Enable bit _after_ setting the direction and
initial value should avoid this issue. Right?